/lgtm

Wondering if it's a good idea to set something like this to all notebooks, further removing the need for user input:

cluster = Cluster(ClusterConfiguration(
    name='raytest',
    namespace= cluster.get_current_namespace(),

I think we would need to add the import too for usage:
from codeflare_sdk.cluster import cluster

Wondering if it's a good idea to set something like this to all notebooks, further removing the need for user input:

cluster = Cluster(ClusterConfiguration(
    name='raytest',
    namespace= cluster.get_current_namespace(),

I think we would need to add the import too for usage: from codeflare_sdk.cluster import cluster

If config doesn't have a namespace set it should use the current working namespace

Will we want to enable the following test as part of this fix, or address in a separate PR? https://github.com/project-codeflare/codeflare-sdk/blob/main/src/codeflare_sdk/cluster/cluster.py#L724

https://github.com/project-codeflare/codeflare-sdk/blob/main/tests/unit_test.py#L579

Apart from the above question, all works as expected!

I'm not sure what the test is testing exactly. Can we leave it out for now?

/lgtm just needs a rebase, thank you!

I ran a demo notebook without providing the namespace and the rhods-notebooks namespace was retrieved from /var/run/secrets/kubernetes.io/serviceaccount/namespace. Works as expected.
/approve

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fiona-Waters

The full list of commands accepted by this bot can be found here.

The pull request process is described here